-
-
Notifications
You must be signed in to change notification settings - Fork 198
refactor(runtime)!: use basename feature of react-router
#2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspress-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for rspress ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
basename feature of react-routerbasename feature of react-router
|
Could this PR make #1677 possible? Example virtual runtime module: `export const base = typeof __RSPRESS_BASE_HREF__ === 'undefined' ? ${JSON.stringify(base)} : __RSPRESS_BASE_HREF__` |
It's really similar to publicPath configuration in webpack There are also some compile-time stages that read the base configuration like plugins, and we can't guarantee that they are correct either if we only modify them at runtime. |
e966bfd to
b1b6011
Compare
b1b6011 to
7a539df
Compare
For the core package, I can refactor it to no rely on the |
|
close #2321 |

Summary
https://github.com/facebook/docusaurus/blob/45065e8d2b5831117b8d69fec1be28f5520cf105/packages/docusaurus/src/client/exports/Link.tsx#L78
I 'm done with
withBaseandremoveBaseandwithoutBaseaddLeadingSlashaddTrailingSlashit is silly and wasting my life
Related Issue
close #2321
Checklist