-
Notifications
You must be signed in to change notification settings - Fork 103
Fix config schema with multivector #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
==========================================
+ Coverage 88.17% 88.24% +0.07%
==========================================
Files 256 256
Lines 17677 17678 +1
==========================================
+ Hits 15586 15600 +14
+ Misses 2091 2078 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
This PR fixes a small bug when exporting the config of the collections.
Multivector config was reported twice in the collection config even if
multivectorflag was not enabled.How to reproduce it
Create a simple python collection as follows:
Looking at the
configvalues you will see multivector config twice even though multivector was not enabled.