Skip to content

Conversation

@robbespo00
Copy link
Contributor

@robbespo00 robbespo00 commented Feb 28, 2025

This PR fixes a small bug when exporting the config of the collections.

Multivector config was reported twice in the collection config even if multivector flag was not enabled.

How to reproduce it

Create a simple python collection as follows:

collection = client.collections.create(
    name="Article",
)
config = client.collections.export_config(
        "Article"
    ).to_dict()

Looking at the config values you will see multivector config twice even though multivector was not enabled.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (7987de5) to head (21c3a4a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1573      +/-   ##
==========================================
+ Coverage   88.17%   88.24%   +0.07%     
==========================================
  Files         256      256              
  Lines       17677    17678       +1     
==========================================
+ Hits        15586    15600      +14     
+ Misses       2091     2078      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robbespo00 robbespo00 marked this pull request as ready for review February 28, 2025 16:06
@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@dirkkul dirkkul merged commit 7f50621 into main May 30, 2025
56 checks passed
@dirkkul dirkkul deleted the rob/fix-multivector-schema branch May 30, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants