package.json content in weave-scope.tgz not always up to date

[fbarl]

For example, commit 3f66348 bumps the weaveworks-ui-components version to 0.12.2, but looking into the corresponding package build https://s3.amazonaws.com/weaveworks-js-modules/weave-scope/3f66348a/weave-scope.tgz, there the package.json file still says "weaveworks-ui-components": "0.11.14".

Looks like a caching issue with the UI part of our build pipeline, possibly related to #3333.

cc @bboreham @guyfedwards @foot

[bboreham]

Yes, the changes in #3333 require you to push a new build image and change .circleci/config.yml to point to it every time the contents of that image change.

[guyfedwards]

A new build image can be created with make .scope_ui_build.uptodate it looks like.

This will keep build times shorter than doing yarn every time. We could look at adding a check for if there is a change in package.json it would either trigger an update or at least tell you in the PR.

[leth]

A couple of other alternatives:

1. remove the baked-in-ui-build-image and add yarn cache to the circleCI cache instead
2. Overwrite the package.json with the up-to-date one

I think 1 would be best as 2 is actually more complex than it sounds once you try and work out how to ensure the package published has the right versions etc.

[guyfedwards]

Yea I wondered about 1, and then was reminded about my previous experiences trying to get node_modules caching to work properly in CI 😄 . That would be a good solution though as yarn is lightning when from cache.

Thinking about it, its a little early days yet but the yarn Plug-n-Play proposal could be helpful in the future yarnpkg/rfcs#101