AlertRulev9 supports dashbord_uid and panel_uid.#655
Open
JaSei wants to merge 3 commits intoweaveworks:mainfrom
Open
AlertRulev9 supports dashbord_uid and panel_uid.#655JaSei wants to merge 3 commits intoweaveworks:mainfrom
JaSei wants to merge 3 commits intoweaveworks:mainfrom
Conversation
Those options was avaialable, but wasn't used and generated alert doesn't have connection to the dashboard and panel. By this fix it's possible.
JamesGibo
requested changes
Jul 16, 2024
Collaborator
JamesGibo
left a comment
JamesGibo
left a comment
There was a problem hiding this comment.
Look good, not tested but does not look to be a breaking change.
Would you be able to add a test for this new annotation logic?
JamesGibo
reviewed
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Add link from alert rule to the dashboard and panel.
Why is it a good idea?
Those options was avaialable, but wasn't used and generated alert doesn't have connection to the dashboard and panel. By this fix it's possible.
Context
Questions