Skip to content

Address remaining CodeRabbit comments from PR #267 #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

Address remaining CodeRabbit comments from PR #267 #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/controllers/concerns/simplefin_items/maps_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ def compute_duplicate_only_flag(stats)
end
end
errs.present? && errs.all? { |m| m.to_s.downcase.include?("duplicate upstream account detected") }
rescue
rescue StandardError => e
Rails.logger.warn("SimpleFin maps: compute_duplicate_only_flag failed: #{e.class} - #{e.message}")
false
end
end
Expand Down
4 changes: 2 additions & 2 deletions db/migrate/20251103185320_drop_was_merged_from_transactions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ def up
end

def down
# Recreate the column for rollback compatibility
# Recreate the column for rollback compatibility with original constraints
unless column_exists?(:transactions, :was_merged)
add_column :transactions, :was_merged, :boolean
add_column :transactions, :was_merged, :boolean, null: false, default: false
end
end
end