-
Notifications
You must be signed in to change notification settings - Fork 94
Update Dockerfile - procps #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
install procps for worker container healthcheck - pgrep Signed-off-by: J4ker <[email protected]>
WalkthroughThe Dockerfile's base package installation command was updated to include the Changes
Sequence Diagram(s)N/A Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jjmata
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done this at least once! ;-)
Added it also to the dev container Dockerfile which for some reason it's got a different list of installed packages. Want to sync them up/test, @J4ker?
CodeSpaces actually stopped working recently, wonder if related.
|
I have very limited skill in this one, I have no idea what devcontainer does |
Don't worry ... that can come later. It's basically a way to wrap docker containers to help set up development environments. |
* Update Dockerfile - procps install procps for worker container healthcheck - pgrep Signed-off-by: J4ker <[email protected]> * Good idea, adding it to dev container --------- Signed-off-by: J4ker <[email protected]> Co-authored-by: Juan José Mata <[email protected]>
install procps for worker container healthcheck - pgrep
Summary by CodeRabbit