Updated list of Canadian registered accounts

[CYBRXT]

Resolution to #1253.

I found a few new registered accounts than what I put in the issue since then, most of which are just tax-deferred retirement accounts of some flavour or another, and then there's the PRPP, which is yet another RRSP-like variation.

Changes have been tested both locally on my dev environment, as well as in Docker by passing through an edited version of investment.rb via the compose.yml file. No abnormal behaviour was observed due to these changes.

The new accounts show up in the subtype selector when creating a new investment account, display correctly in the account sidebar/settings, and have the correct tags:

Summary by CodeRabbit

• New Features
  • Added support for additional Canadian account types: FHSA, RDSP, DPSP, PRPP, LIF, RLIF, PRIF, LRIF and Non-Registered, expanding coverage of Canadian investment account options.
  • Adjusted ordering of Canadian account types in lists and displays, moving RRSP to follow TFSA for improved consistency.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9fb2dd81-b726-475e-9bf4-8d453c325ecf

📥 Commits

Reviewing files that changed from the base of the PR and between c33d040 and c7a82d3.

📒 Files selected for processing (1)

• app/models/investment.rb

🚧 Files skipped from review as they are similar to previous changes (1)

• app/models/investment.rb

---

📝 Walkthrough

Walkthrough

Expanded Canadian entries in Investment::SUBTYPES: added non-registered, fhsa, rdsp, dpsp, prpp, lif, lrif, prif, rlif; repositioned rrsp to appear after tfsa. No other files changed.

Changes

Cohort / File(s)	Summary
Investment Subtypes Configuration app/models/investment.rb	Updated Investment::SUBTYPES: added Canadian subtypes non-registered, fhsa, rdsp, dpsp, prpp, lif, lrif, prif, rlif with short, long, region: "ca", and tax_treatment metadata; moved rrsp to follow tfsa.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related issues

• List of Canadian investment accounts in app/models/investment.rb is missing the FHSA, RDSP, and DPSP #1253: Adds FHSA, RDSP, DPSP and other Canadian subtypes to Investment::SUBTYPES, aligning with this PR's additions.

Possibly related PRs

• Add tax treatment classification for investment accounts with international support #693: Modifies Investment::SUBTYPES with region-aware subtype entries and tax treatment metadata — closely related.
• UI Suggestions for Account Types in Setup Modal + Stats-Based Inactive Handling #368: Updates the same Investment::SUBTYPES constant to add/reorder Canadian subtype entries.

Suggested reviewers

• jjmata

Poem

🐇 I hopped through code with nimble paws,
I lined up FHSA, RDSP, and laws,
Non-registered joined the trail,
RRSP shuffled after TFSA's tale,
A rabbit cheers — Canada’s accounts set sail! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change—adding new Canadian registered account types to the Investment::SUBTYPES constant, directly addressing PR issue #1253.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}