Skip to content

Support for PEP 614 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gvanrossum merged 2 commits into from
Mar 27, 2020
Merged

Support for PEP 614 #24

gvanrossum merged 2 commits into from
Mar 27, 2020

Conversation

@pablogsal
Copy link

@pablogsal pablogsal commented Mar 24, 2020

Closes: #22

@pablogsal
Copy link
Author

pablogsal commented Mar 24, 2020 •
edited
Loading

Right now the tests in Tools/peg_generator/ and we cannot add this to the original pegen repo because it only supports 3.8. Should we land this as is or should we fix either of these situations first?

Edit: I was not aware of Lib/test/test_peg_parser.py

@pablogsal pablogsal mentioned this pull request Mar 24, 2020
Merged
@lysnikolaou
Copy link
Member

lysnikolaou commented Mar 24, 2020

You can add some tests to Lib/test/test_peg_parser.py that test this.

lysnikolaou
lysnikolaou approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gvanrossum
Copy link

gvanrossum commented Mar 27, 2020

I think the tests should pass if this is merged, so doing that.

@gvanrossum gvanrossum merged commit 4410737 into pegen Mar 27, 2020
@gvanrossum gvanrossum deleted the grammar branch March 27, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

New decorator syntax

4 participants

@pablogsal @lysnikolaou @gvanrossum