fix: Enable plugin usage in ESM projects by replacing require.resolve with hybrid resolver#255
Open
francesco-carrella wants to merge 2 commits intowd-David:mainfrom
Open
Conversation
added 2 commits
August 24, 2025 12:54
… with hybrid resolver - Replace require.resolve() calls with hybrid resolver that works in both CJS and ESM - Use Node.js createRequire() API for proper ESM compatibility - Remove broken ESM fallback code that caused syntax errors - Add comprehensive tests for dual module compatibility - Maintain full backward compatibility with existing CJS usage Fixes plugin usage in modern ESM-based build setups where require.resolve() is not available.
- Add prepare script that runs build automatically when installing from GitHub - Ensures dist/ files are generated even when not committed to repo - Enables direct GitHub installation with 'npm install github:user/repo'
|
@wd-David Could you take a look, I need this in my projects aswell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require.resolve()calls with hybrid resolver that works in both CommonJS and ESM environmentsChanges
createRequire()API for ESM compatibilityrequire.resolve()calls to usehybridResolve()Test plan