This repository was archived by the owner on Dec 6, 2023. It is now read-only.
Abort if current and target Node versions are the same (closes #78)#87
Open
alexilyaev wants to merge 1 commit intowbyoung:masterfrom
Open
Abort if current and target Node versions are the same (closes #78)#87alexilyaev wants to merge 1 commit intowbyoung:masterfrom
alexilyaev wants to merge 1 commit intowbyoung:masterfrom
Conversation
Author
|
@wbyoung Hope you're still active here. |
Owner
|
I understand the point of wanting to optimize this, but I'm reluctant to make this change for a few reasons:
If we can resolve these concerns, then I think this is a go. But I'm skeptical at this point. Also, I honestly don't use this project any more. I've tried to find time to finalize converting it to Babel & more modern JS, but haven't even completed that. So if you're interested in contributing, someone helping tackle and maintain complexity could help push things like this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to handle #78.
The implementation is very simple and probably doesn't cover edge cases.
But it works for me.
I'd be glad to expand upon this, but first wanted to get some traction going.
Also, some tests are failing, not sure how to fix that.
Maybe move the solution to the Node.js side.
I did in Bash thinking it would be much faster.