Skip to content

fix: respect tool_choice="none" by excluding tools from template #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awanawana wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: respect tool_choice="none" by excluding tools from template #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions vllm_mlx/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1421,8 +1421,11 @@ async def create_chat_completion(request: ChatCompletionRequest, raw_request: Re
if request.specprefill_keep_pct is not None:
chat_kwargs["specprefill_keep_pct"] = request.specprefill_keep_pct

# Add tools if provided
if request.tools:
# Add tools if provided (but skip if tool_choice="none")
# When tool_choice="none", models like Qwen2.5 and Llama 3.x still activate
# tool-calling if tools are present in the template context. To properly
# disable tool calling, we must not pass tools to the template at all.
if request.tools and request.tool_choice != "none":
chat_kwargs["tools"] = convert_tools_for_template(request.tools)

if request.stream:
Expand Down