MONIT-31965 Add debug level payload logging #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a logger in LogDataSubmissionTask and log a log message before it is sent to the backend.
Add a logger in LogDataSubmissionTask and log a log message before it is sent to the backend(if the root logger's level is defined as DEBUG).
xuranchen
approved these changes
Nov 22, 2022
laullon
reviewed
Nov 22, 2022
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonTypeInfo(use = JsonTypeInfo.Id.CLASS, property = "__CLASS") | ||
| public class LogDataSubmissionTask extends AbstractDataSubmissionTask<LogDataSubmissionTask> { | ||
| private static final Logger LOGGER = LogManager.getLogger(LogDataSubmissionTask.class); |
Contributor
There was a problem hiding this comment.
Create a logger just for this.
Contributor
Author
There was a problem hiding this comment.
@laullon Can you please explain a little bit? Are you suggesting creating a logger just for the LogDataSubmissionTask.execute()? Is the OTLP_DATA_LOGGER just an example? If yes, I have another question. The LogDataSubmissionTask.java class does not have any other functionality like the OtlpTraceUtils.java class. Does it make sense to create a logger just for the execute() method? Please guide.
Fixing logger as per the PR comments.
laullon
approved these changes
Nov 24, 2022
Contributor
|
Please make sure this change cam be apply to |
laullon
added a commit
that referenced
this pull request
Jan 24, 2023
* dev: Add debug logging (#823) Fix for CVE-2022-3171 (#825) MONIT-32454 Update Dockerfile to create a directory (#822) Add 5 second timeout for PushAgent tests (#820) [release] prepare for next development iteration [release] prepare release for proxy-12.1 update open_source_licenses.txt for release 12.1 Update wavefront.conf.default (#819) Proxy V12.2 [MONIT-32096] Better Local Hostname detection (#817) changes for linux packages solve bug detected on v12.0 (#816) MONIT-31965 Add debug level payload logging (#813) deosu/monit 31993: add fluentBit support (#812) # Conflicts: # proxy/pom.xml # proxy/src/main/java/com/wavefront/agent/AbstractAgent.java # proxy/src/main/java/com/wavefront/agent/ProxyConfig.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a logger in LogDataSubmissionTask and log a payload before it is sent to the backend(if the root logger's level is defined as DEBUG).