chore: move dev deps to devDependencies #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1
@watson The main motivation for this is a breakage in attempting to run eslint in https://github.com/open-telemetry/opentelemetry-js-contrib as somewhat described in this comment. That repo installs eslint at the top-level for linting. It is a monorepo with packages in subdirs. Some of the package subdirs have a dependency on test-all-versions@5, which deps on this package. Because this package installs eslint@6, attempts to lint in those subdirs accidentally get this eslint@6 and linting breaks -- hitting an incompatibility error between various eslint-related packages (prettier/eslint-plugin-prettier#434).
The easiest fix is to:
[email protected]The
"parse-env-string": "^1.0.0",range in test-all-versions@5 will then get the fixed version. Thanks.