Skip to content

[Feature] Detect solano-ci #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
watson merged 3 commits into from
Aug 14, 2018
Merged

[Feature] Detect solano-ci #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e17ef95
feat: detect solano-ci
sibiraj-s Jul 31, 2018
1c24165
chore: remove unwanted env check
sibiraj-s Aug 14, 2018
33e48e9
docs: update README.md
sibiraj-s Aug 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ var vendors = [
['TASKCLUSTER', 'TaskCluster', 'TASK_ID', 'RUN_ID'],
['GOCD', 'GoCD', 'GO_PIPELINE_LABEL'],
['BITBUCKET', 'Bitbucket Pipelines', 'BITBUCKET_COMMIT'],
['CODEBUILD', 'AWS CodeBuild', 'CODEBUILD_BUILD_ARN']
['CODEBUILD', 'AWS CodeBuild', 'CODEBUILD_BUILD_ARN'],
['TDDIUM', 'Solano CI', 'TDDIUM']
]

exports.name = null
Expand All @@ -43,6 +44,7 @@ exports.isCI = !!(
env.CI || // Travis CI, CircleCI, Gitlab CI, Appveyor, CodeShip
env.CONTINUOUS_INTEGRATION || // Travis CI
env.BUILD_NUMBER || // Jenkins, TeamCity
env.TDDIUM || // Solano CI
Copy link
Owner

@watson watson Aug 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to add TDDIUM to this list as it's taken care of by exports.name which will be set to Solano CI if the TDDIUM environment variable is present

exports.name ||
false
)
4 changes: 4 additions & 0 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,14 @@ assert.equal(ci.TASKCLUSTER, false)
assert.equal(ci.GOCD, false)
assert.equal(ci.BITBUCKET, false)
assert.equal(ci.CODEBUILD, false)
assert.equal(ci.TDDIUM, false)

// Not CI
delete process.env.CI
delete process.env.CONTINUOUS_INTEGRATION
delete process.env.BUILD_NUMBER
delete process.env.TRAVIS
delete process.env.TDDIUM
clearRequire('./')
ci = require('./')

Expand All @@ -56,6 +58,7 @@ assert.equal(ci.TASKCLUSTER, false)
assert.equal(ci.GOCD, false)
assert.equal(ci.BITBUCKET, false)
assert.equal(ci.CODEBUILD, false)
assert.equal(ci.TDDIUM, false)

// Unknown CI
process.env.CI = 'true'
Expand All @@ -82,3 +85,4 @@ assert.equal(ci.TASKCLUSTER, false)
assert.equal(ci.GOCD, false)
assert.equal(ci.BITBUCKET, false)
assert.equal(ci.CODEBUILD, false)
assert.equal(ci.TDDIUM, false)