Skip to content

chore: Remove agent-generated workflow slop and fix CI/CD#4

Open
glassBead-tc wants to merge 2 commits intomainfrom
cleanup/remove-slop-workflows
Open

chore: Remove agent-generated workflow slop and fix CI/CD#4
glassBead-tc wants to merge 2 commits intomainfrom
cleanup/remove-slop-workflows

Conversation

@glassBead-tc
Copy link
Copy Markdown
Contributor

Summary

Cleans up 966 lines of non-functional agent-generated workflows and fixes remaining CI/CD issues.

Changes

Deleted Workflows (966 lines)

  1. claude-auto-implement.yml (283 lines)

    • Was trying to install non-existent Claude CLI from https://claude.ai/cli/install.sh
    • Auto-committed code without approval
    • Called npm run verify:claude which doesn't exist
  2. claude-verification.yml (112 lines)

    • Ran on every push to main/develop
    • Called non-existent Claude CLI and npm scripts
    • Wasted Actions minutes on failed runs
  3. waldzell-agentic-enhancement.yml (571 lines)

    • Ran daily at 2 AM UTC automatically
    • Referenced deleted agentic-scripts/ directories
    • "Self-Improvement Orchestration" that called non-existent scripts
    • Meta-meta-evolution nonsense

Fixed ci.yml

  • ✅ Removed hardcoded develop branch (doesn't exist)
  • ✅ Upgraded Node.js 18 → 20 (Node 18 is EOL as of April 2025)
  • ✅ Removed TODO comment in CI itself

Impact

  • No more failed workflow runs from non-existent endpoints
  • No more daily auto-runs at 2 AM UTC
  • No more wasted Actions minutes
  • CI/CD is now clean and functional

Testing

CI will run on this PR and should pass with the fixed configuration.


Pull Request opened by Augment Code with guidance from the PR author

- Remove agentic-scripts/ (belongs in claude-bloom repo, not here)
- Remove .devcontainer/ (never requested, auto-added by agent)
- Update AUTOMATION.md to remove devcontainer references

These were added by agents without explicit request and contained:
- Outdated model references (claude-3-sonnet-20240229)
- Invalid JSON syntax
- Unnecessary complexity for this project

Keeping the codebase focused on ADK TypeScript implementation.
- Remove claude-auto-implement.yml (283 lines of non-functional automation)
- Remove claude-verification.yml (112 lines calling non-existent endpoints)
- Remove waldzell-agentic-enhancement.yml (571 lines of daily auto-runs)
- Fix ci.yml: remove 'develop' branch, upgrade Node 18→20, remove TODO
- Total cleanup: 966 lines of slop removed

These workflows were:
- Calling non-existent Claude CLI endpoints
- Running non-existent npm scripts
- Referencing deleted agentic-scripts directories
- Triggering daily at 2 AM UTC without approval
- Wasting GitHub Actions minutes on failed runs

CI/CD is now clean and functional.
Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Summary

This PR performs a comprehensive cleanup of the repository by removing 966 lines of non-functional agent-generated workflows and configurations. The changes eliminate problematic automation that was attempting to use non-existent Claude CLI tools, calling undefined npm scripts, and running daily automated processes that would consistently fail.

The cleanup removes several categories of problematic code:

  1. GitHub Actions workflows that referenced non-existent endpoints like https://claude.ai/cli/install.sh and would run daily at 2 AM UTC without accomplishing anything productive
  2. Development container configurations including Docker files and initialization scripts that contained broken Claude CLI integrations
  3. Agentic scripts directory with complex bash utilities for memory management, debugging, and AI agent evolution that relied on non-functional tooling
  4. Configuration files supporting the now-removed automation systems

The PR also fixes the main CI workflow by removing references to a non-existent develop branch, upgrading from Node.js 18 to 20 (since Node 18 reaches EOL in April 2025), and cleaning up TODO comments. This change transforms the repository from an over-engineered system attempting autonomous self-improvement to a clean, focused TypeScript ADK with reliable CI/CD.

The changes align with the project's core purpose as documented in the codebase overview - providing a framework for developing AI agents using TypeScript with emphasis on type safety and modularity, rather than being a self-modifying autonomous system.

Important Files Changed

Changed Files
Filename Score Overview
.github/workflows/claude-auto-implement.yml 5/5 Deleted 283-line workflow that auto-committed code and referenced non-existent Claude CLI
.github/workflows/claude-verification.yml 5/5 Removed 112-line workflow that ran on every push but called non-existent endpoints
.github/workflows/waldzell-agentic-enhancement.yml 5/5 Eliminated 571-line daily automated workflow with self-improvement orchestration
.github/workflows/ci.yml 4/5 Fixed CI by removing non-existent branch refs, upgrading Node.js 18→20, cleaning TODO
agentic-scripts/dev-tools/intelligent-debugger.sh 5/5 Removed 315-line debugging tool that referenced non-existent Claude CLI and auto-fixed production
agentic-scripts/memory/memory-manager.sh 5/5 Deleted 452-line memory management script with complex AI-powered file operations
agentic-scripts/evolution/adas-meta-agent.sh 5/5 Removed 162-line meta-agent script that generated and executed bash scripts automatically
agentic-scripts/README.md 5/5 Deleted documentation for the non-functional agentic enhancement system
agentic-scripts/config.json 5/5 Removed configuration file for the deleted agentic scripts system
.devcontainer/devcontainer.json 4/5 Deleted VS Code dev container config with Node.js 18 and broken Claude integration
.devcontainer/Dockerfile 4/5 Removed Docker configuration attempting to install non-existent Claude CLI
.devcontainer/init-workspace.sh 4/5 Deleted environment initialization script with broken Claude CLI references
AUTOMATION.md 2/5 Modified to remove DevContainer references but still documents non-existent automation

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it primarily removes non-functional code
  • Score reflects that deletions eliminate problematic automation without affecting core functionality
  • Pay close attention to AUTOMATION.md which still documents non-existent features and may need further cleanup

Sequence Diagram

sequenceDiagram
    participant User
    participant GitHubActions as "GitHub Actions"
    participant CI as "CI/CD Pipeline"
    participant QuickChecks as "Quick Checks Job"
    participant QualityGates as "Quality Gates Job"
    participant TestSuite as "Test Suite Job"
    participant BuildVerification as "Build Verification Job"
    participant FinalGate as "Final Gate Job"

    User->>GitHubActions: "Push to main or create PR"
    GitHubActions->>CI: "Trigger CI/CD Pipeline workflow"
    
    Note over CI: "Cancel in-progress runs for same ref"
    
    CI->>QuickChecks: "Start Quick Checks (parallel)"
    CI->>QualityGates: "Start Quality Gates (parallel)"
    
    QuickChecks->>QuickChecks: "Checkout code, setup Node.js 20"
    QuickChecks->>QuickChecks: "npm ci, TypeScript check, ESLint"
    QuickChecks->>QuickChecks: "Detect changed TypeScript files"
    QuickChecks-->>CI: "Quick checks complete"
    
    QualityGates->>QualityGates: "Check for new TODO/FIXME/placeholders"
    QualityGates->>QualityGates: "Check for empty functions"
    QualityGates-->>CI: "Quality gates complete"
    
    CI->>TestSuite: "Start Test Suite (needs quick-checks)"
    TestSuite->>TestSuite: "Run tests with coverage"
    TestSuite->>TestSuite: "Upload coverage report"
    TestSuite-->>CI: "Tests complete"
    
    CI->>BuildVerification: "Start Build (needs quick-checks)"
    BuildVerification->>BuildVerification: "npm run build"
    BuildVerification->>BuildVerification: "Verify dist/ output"
    BuildVerification->>BuildVerification: "Upload build artifacts"
    BuildVerification-->>CI: "Build complete"
    
    CI->>FinalGate: "All Checks Passed (needs all jobs)"
    FinalGate->>FinalGate: "Verify all jobs succeeded"
    FinalGate-->>GitHubActions: "CI/CD status result"
    GitHubActions-->>User: "Workflow completion notification"
Loading

Additional Comments (2)

  1. AUTOMATION.md

    logic: These npm scripts (claude:analyze, claude:fix-any, claude:gen-tests, quality:gate) don't exist in package.json and were part of the non-functional automation workflows that were deleted in this PR

    Context Used: Rule from dashboard - Unless specified in a comment, we will never intentionally leave a stub in a codebase. These should ... (source)

  2. AUTOMATION.md, line 72 (link)

    logic: The verify:claude script referenced here was mentioned in the deleted claude-auto-implement.yml as non-existent

    Context Used: Rule from dashboard - Unless specified in a comment, we will never intentionally leave a stub in a codebase. These should ... (source)

Context used:

Rule from dashboard - Unless specified in a comment, we will never intentionally leave a stub in a codebase. These should ... (source)

13 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant