refactor: use new_createPages in examples #997
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
with the tests failing I'm seeing new_defineRouter needs to be mocked |
|
I am currently thinking through how best to test also, in place of the skip tests: we should probably eventually add tests for the new define router. |
This comment was marked as resolved.
This comment was marked as resolved.
tylersayshi
changed the title
|
react tweet example seems fine weave render does not render anything when navigating away from, then back to home 🤔 |
| <Link | ||
| to={'/nested/bar' as never} | ||
| to={'/bar'} | ||
| pending={<Pending isPending />} | ||
| notPending={<Pending isPending={false} />} | ||
| > | ||
| Nested / Bar | ||
| Bar | ||
| </Link> |
There was a problem hiding this comment.
@dai-shi is this bad link here intentionally?
the as never shows me that the type error was known, but I can't think of a reason why we would want a broken link in the example.
There was a problem hiding this comment.
I'm not sure your original intent, but I thought it's an intentional 404 link.
There was a problem hiding this comment.
changed the link back but changed the text to make it obvious that link will 404 if that's ok with you
2 participants
Moving to new_createPages
I left
createPagesin the docs since we will drop the existingcreatePagessoon and replace it withnew_createPagesunder the same name.