-
-
Notifications
You must be signed in to change notification settings - Fork 168
test: catch an error in client router #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: catch an error in client router #776
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add a new entry in tsconfig.e2e.json.
Please run prettier too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may not preserve this capability of using error boundary in client layout, and we may change the capability and this test in the future.
But, meanwhile, adding this test to notice regression would be nice.
Thanks for your contribution.
It covers #696 and #741.
The test aims at how to implement auth features on the app side.
Considerations:
I'm so glad to send my first PR to Waku, thank you!