Skip to content

Conversation

@t6adev
Copy link
Contributor

@t6adev t6adev commented Jul 4, 2024

It covers #696 and #741.
The test aims at how to implement auth features on the app side.

Considerations:

  1. Our client router has to handle 4xx errors that the server responds
  2. Middleware can be a validator to respond to 200 or 4xx status on requests

I'm so glad to send my first PR to Waku, thank you!

@vercel
Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jul 7, 2024 1:00pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add a new entry in tsconfig.e2e.json.
Please run prettier too.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may not preserve this capability of using error boundary in client layout, and we may change the capability and this test in the future.
But, meanwhile, adding this test to notice regression would be nice.

Thanks for your contribution.

@dai-shi dai-shi merged commit 7388766 into wakujs:main Jul 10, 2024
@t6adev t6adev deleted the test-catch-error-in-client-router branch July 10, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants