breaking(minimal): handleBuild API for build #1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Open
dai-shi
changed the title
Member
|
this change is significant. I'm curious, what was the motivation for this refactor? |
Member
Author
|
It's to support api routes. Long journey. |
Member
wow! I did not expect this to be so disruptive to the current code 😲 |
Member
Author
|
API routes are technically already possible with 39_api example. |
rmarscher
reviewed
Dec 31, 2024
Comment on lines
+65
to
+70
| htemlHead: generateHtmlHead(), | ||
| }), | ||
| async () => ({ | ||
| type: 'defaultHtml' as const, | ||
| pathname: '/no-ssr', | ||
| htemlHead: generateHtmlHead(), |
Member
Author
There was a problem hiding this comment.
Oh, no. Yeah, thanks for pointing it out.
dai-shi
added a commit
that referenced
this pull request
Dec 31, 2024
yokos2
added a commit
to yokos2/react-yoko-portfolio
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also changes define-router