-
Notifications
You must be signed in to change notification settings - Fork 33
Outline RFC 46: Single paragraph rich text fields/blocks #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Outline RFC 46: Rich text segment blocks | ||
|
|
||
| * RFC: 46 | ||
| * Authors: Karl Hobley | ||
| * Created: 2019-11-18 | ||
| * Last Modified: 2019-11-18 | ||
|
|
||
| ## Abstract | ||
|
|
||
| This is an outline proposal for a new field and block type which would behave like a ``RichTextField``/``RichTextBlock`` but only allows a single segment of text. | ||
|
|
||
| Inline elements such as formatting and hyperlinks may be allowed. But block elements like paragraphs, images and bullet points will not. The HTML segment in the database will not be enclosed in a `<p>` tag giving developers more flexibility in where it can be used. | ||
|
|
||
| I think this will be very useful for: | ||
| - Introductions/summaries which can usually only be one paragraph but use rich text fields as they may need inline formatting. For example, the sentence above "Tom Dyson" in https://wagtail.io/blog/wagtail-2-7/. | ||
| - Image captions | ||
| - Inline styling in titles. For example https://torchbox.com/digital-products/ | ||
| - Forcing editors to use separate rich text blocks in streamfields | ||
thibaudcolas marked this conversation as resolved.
Show resolved
Hide resolved
thibaudcolas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| I think it would also be very useful to have an internal ``RichTextSegment`` type to represent the values of these fields. Having a separate type rather than reusing ``RichText`` would be useful because logic, like diffing and translating, would work very differently when working with individual segments. | ||
thibaudcolas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ## Specification | ||
|
|
||
| I don't think this would be a very technically challenging change to make, but I'm leaving this bit out since I'm only looking to get feedback on the general idea for now. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.