This repository was archived by the owner on Mar 23, 2023. It is now read-only.
Track tmp test empty dir.#20
Merged
Merged
Conversation
Owner
|
Tests already pass, I don't see the point of that edit |
ghost
assigned
Contributor
Author
|
because, you already have that tmp dir :p, but it is not tracked, clone the repo and you will understand what I mean |
Owner
|
The Temp directory is not tracked either, the PR just change the name of the folder, it doesn't do any other things that make it traceable. All the travis build clone the repo, and they passed the tests : https://travis-ci.org/kamisama/Cake-Resque/jobs/6872684 |
Contributor
Author
|
The pr tracks tmp/empty file, which makes tmp tracked. I just changed the name to be consistent with unix hierarchy :) Also, tmp dir must have others permissions so that files can be created inside. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that Resque_Job_CreatorTest tests passes.