Skip to content

Addition Info NFTS Pallet#4476

Merged
filippoweb3 merged 18 commits intomasterfrom
update-nft-pallet-info2
Feb 15, 2023
Merged

Addition Info NFTS Pallet#4476
filippoweb3 merged 18 commits intomasterfrom
update-nft-pallet-info2

Conversation

@filippoweb3
Copy link
Copy Markdown
Contributor

@filippoweb3 filippoweb3 commented Feb 14, 2023

More information for devs willing to use the pallet to build dApps (uploading images, metadata and attributes)

@filippoweb3 filippoweb3 added the A1 - In Progress Not ready for review yet. label Feb 14, 2023
@filippoweb3 filippoweb3 self-assigned this Feb 14, 2023
@filippoweb3
Copy link
Copy Markdown
Contributor Author

filippoweb3 commented Feb 14, 2023

@jsidorenko @SaltyCucumber
I added more info about what devs can do to upload images and metadata. Let me know if it makes sense. One question: where can I add CID when minting an item on the chain using the extrinsic tab?

@VadimSaveljev
Copy link
Copy Markdown

VadimSaveljev commented Feb 14, 2023 •
edited
Loading

@jsidorenko @SaltyCucumber I added more info about what devs can do to upload images and metadata. Let me know if it makes sense. One question: where can I add CID when minting an item on the chain using the extrinsic tab?

when updating collection: setCollectionMetadata
put CID in data field

when updating NFT: setMetadata
put CID in data field

@filippoweb3 filippoweb3 added A2 - Please Review Pull request is ready for review. and removed A1 - In Progress Not ready for review yet. labels Feb 14, 2023
@filippoweb3 filippoweb3 requested a review from DrW3RK February 14, 2023 13:38
VadimSaveljev
VadimSaveljev reviewed Feb 14, 2023
View reviewed changes
DrW3RK
DrW3RK approved these changes Feb 15, 2023
View reviewed changes
filippoweb3 and others added 4 commits February 15, 2023 14:00
@filippoweb3 @DrW3RK
Update docs/learn/learn-nft-pallets.md
5e02fe5 
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
@filippoweb3 @DrW3RK
Update docs/learn/learn-nft-pallets.md
e8e91bb 
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
@filippoweb3 @DrW3RK
Update docs/learn/learn-nft-pallets.md
26dfafd 
Co-authored-by: Radha <86818441+DrW3RK@users.noreply.github.com>
tiny edit, run grammarly
4814475
@filippoweb3 filippoweb3 merged commit 405a738 into master Feb 15, 2023
@filippoweb3 filippoweb3 deleted the update-nft-pallet-info2 branch February 15, 2023 13:05
@jsidorenko
Copy link
Copy Markdown
Contributor

jsidorenko commented Feb 16, 2023

"and there will be the option to attach paritytech/substrate#12437."
Can we remove this, please? That was just an idea which didn't get into the roadmap

@filippoweb3
Copy link
Copy Markdown
Contributor Author

filippoweb3 commented Feb 16, 2023

"and there will be the option to attach paritytech/substrate#12437." Can we remove this, please? That was just an idea which didn't get into the roadmap

see this new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrW3RK DrW3RK DrW3RK approved these changes

+1 more reviewer

@VadimSaveljev VadimSaveljev VadimSaveljev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@filippoweb3 filippoweb3

Labels

A2 - Please Review Pull request is ready for review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@filippoweb3 @VadimSaveljev @jsidorenko @DrW3RK