Skip to content

Upgrade Gafi application from level 2 to level 3#925

Merged
Noc2 merged 10 commits intow3f:masterfrom
cryptovietinfolabs:master
May 13, 2022
Merged

Upgrade Gafi application from level 2 to level 3#925
Noc2 merged 10 commits intow3f:masterfrom
cryptovietinfolabs:master

Conversation

@grindydev
Copy link
Copy Markdown
Contributor

@grindydev grindydev commented May 4, 2022 •
edited
Loading

Project Abstract

Please provide a brief description of your project here summarising key points (1-2 paragraphs).

If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

For which grant level are you applying?

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $50,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for > $100k Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied, renamed ( project_name.md) and updated.
  • A BTC or Ethereum (DAI/USDT) address for the payment of the milestones is provided inside the application.
  • I have read and acknowledged the terms and conditions.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted.

How Did You Hear About our grants program?

  • Social Media
  • Hackathon
  • Personal Recommendation
  • Substrate Builders Program
  • Investor/VC
  • Online Search
  • Other: _______

grindydev and others added 9 commits February 20, 2022 14:51
@grindydev
create HE-Chain Proposal
39a2c1a
@grindydev
change payment to Ethereum network
9623f4d
@grindydev
remove EVM to deliverables, add HE-Chain DAO
a227e46 
the main focus of the team is to build pallets aka chain logic, so remove EVM to deliverables.
add the explaining how HE-Chain DAO works
reduce fund
@grindydev
Remove milestone 3, add more work to milestone 2
bc83d35 
Remove milestone 3 to reduce a lot of effort to create the same thing as Snowfork
We need to test as end-user, write documents/articles of what is HE-chain, how to use HE-Chain...
@grindydev
Add Weights/Benchmarking to deliveries
7b629a7 
Weights and Benchmarking are the must-have of our application, these are a part to make HE-Chain fulfill its purpose.
@grindydev
rename proposal HE-Chain to Gafi
c71ca65
@grindydev
add pallet_staking_pool + pallet_proof_mapping to milestone 1
23c5a5f
@grindydev
Merge branch 'w3f:master' into master
37a5632
@grindydev
Task/upgrade gafi level3 (#1)
01e19a5 
* update content

* update milestone delivery

* spell
@grindydev
Copy link
Copy Markdown
Contributor Author

grindydev commented May 4, 2022

Hi, after months of building, Substrate gives us more clarity on the possible features that we did not add to the Gafi grant application in the first place. We would like to add pallet sponsored pool, pallet cache, and pallet game creator to the delivery of milestones 2 and 3 (milestone 1 we have passed).

@semuelle semuelle self-assigned this May 5, 2022
semuelle
semuelle suggested changes May 5, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, @mutobui.

  1. Why is Game Creator its own pallet? From your description, it is a mechanism to divert funds to a game's creator, which sounds like something that could be easily implemented in your existing functions.
  2. What is the purpose of caching data in a pallet? I couldn't find an explanation for this pallet and functionality anywhere.

To be honest, I am a bit hesitant to grant another 20,000 USD for pallets that will be tightly coupled with your other, already very specific pallets. I would be more comfortable funding this as a follow-up grant after seeing your current plan in action. In any case, I will share your amendment with the rest of the team.

@semuelle semuelle added the ready for review The project is ready to be reviewed by the committee members. label May 5, 2022
@grindydev
Copy link
Copy Markdown
Contributor Author

grindydev commented May 5, 2022

Hi @semuelle, thanks for the review, and sorry for the lack of info.

Pallet game-creator: will deliver on version v0.2.5 so right now it's just on our design, with the purpose of rewarding the game's creator, pallet game-creator provides the following main functionality:

  1. The game's creator claims the ownership of the contract by giving transaction hash
  2. Withdraw the transaction fee reward
  3. Change the ownership

pallet-cache: we need the mechanism to store data temporarily to prevent player spam join<->leave pools, please look at the beta version of pallet-cache: https://github.com/cryptoviet/gafi/tree/v0.2.0/pallets/pallet-cache

@semuelle
Copy link
Copy Markdown
Contributor

semuelle commented May 9, 2022

player spam join<->leave pools

Can you expand on this? People spam transactions? Why would they do that? Sounds like a problem with the economics.

@grindydev
Copy link
Copy Markdown
Contributor Author

grindydev commented May 10, 2022

Every 30 minutes, players in the pool get a specific number of tickets to use for a discount on the transaction fee. When they run out of tickets they would rejoin to refresh the tickets, but the pallet cache will prevent that by giving the remaining tickets to that player when they rejoin.

Noc2
Noc2 approved these changes May 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m happy to support this, but it might be hard to get the five approvals.

gautamdhameja
gautamdhameja approved these changes May 11, 2022
View reviewed changes
Copy link
Copy Markdown

@gautamdhameja gautamdhameja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this interesting solution and I would be looking forward to seeing it built. All the best.

@grindydev
Copy link
Copy Markdown
Contributor Author

grindydev commented May 12, 2022

Thank you for being so supportive, after receiving the grant from milestone 1 we have the momentum. Until now, Gafi is just at the beginning of the long development process, therefore we believe Substrate will give us more ideas and solutions to achieving Level 3.

hakan-w3f
hakan-w3f approved these changes May 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@hakan-w3f hakan-w3f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to seeing this challenging Substrate based project.

takahser
takahser approved these changes May 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the price is rather high for what you're planning to additionally deliver. However, given the high quality of your M1 delivery, I'm willing to support this amendment. Looking forward to your future deliveries! 👍

@Noc2 Noc2 merged commit ea419fa into w3f:master May 13, 2022
xgreenx pushed a commit to Supercolony-net/Open-Grants-Program that referenced this pull request Jun 16, 2022
@grindydev @xgreenx
Upgrade Gafi application from level 2 to level 3 (w3f#925)
cc5a3f3 
* create HE-Chain Proposal

* change payment to Ethereum network

* remove EVM to deliverables, add HE-Chain DAO

the main focus of the team is to build pallets aka chain logic, so remove EVM to deliverables.
add the explaining how HE-Chain DAO works
reduce fund

* Remove milestone 3, add more work to milestone 2

Remove milestone 3 to reduce a lot of effort to create the same thing as Snowfork
We need to test as end-user, write documents/articles of what is HE-chain, how to use HE-Chain...

* Add Weights/Benchmarking to deliveries

Weights and Benchmarking are the must-have of our application, these are a part to make HE-Chain fulfill its purpose.

* rename proposal HE-Chain to Gafi

* add pallet_staking_pool + pallet_proof_mapping to milestone 1

* Task/upgrade gafi level3 (#1)

* update content

* update milestone delivery

* spell

* update pallet game-creator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laboon laboon laboon approved these changes

+5 more reviewers

@semuelle semuelle semuelle requested changes

@gautamdhameja gautamdhameja gautamdhameja approved these changes

@takahser takahser takahser approved these changes

@Noc2 Noc2 Noc2 approved these changes

@hakan-w3f hakan-w3f hakan-w3f approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@semuelle semuelle

Labels

ready for review The project is ready to be reviewed by the committee members.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@grindydev @semuelle @laboon @gautamdhameja @takahser @Noc2 @hakan-w3f