OpenBrush follow-up 2 milestone 7 modification#1149
Merged
Noc2 merged 1 commit intow3f:masterfrom Sep 6, 2022
Merged
Conversation
Noc2
approved these changes
Aug 30, 2022
laboon
approved these changes
Aug 30, 2022
takahser
approved these changes
Sep 6, 2022
SBalaguer
approved these changes
Sep 6, 2022
3 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many developers are asking for the feature to test cross-contract calls in unit tests because it is hard to mock it each time and makes the testing much harder, forcing people to write integration tests with Redspot, Swanky, and Typechain-Polkadot.
We want to prioritize this task and deliver the trait refactoring in ink! later(Initially, we plan to implement an advanced testing framework in milestone eight it is why we can swap those tasks). Because it is a hot topic and after discussion in the issue and element channel, it is clear how it should be implemented=)
The scope of work is the same and also related to the ink! repository. Because it requires modification of the off-chain environment.
Grant level
#921