Ares Protocol milestone 1

[jiyilanzhou]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is done by the same account, which is responsible for the pull request of the accepted application.
• In the case of acceptance, the payment will be transferred to the initial BTC payment address.

[Noc2]

Thanks for the delivery of the milestone. We will look into it as soon as possible.

[Noc2]

I started to look into your delivery. You can find my notes here. However, it doesn’t seem like you are using an off-chain worker, like you originally said in the application. The documentation also doesn’t contain any example on how to use the pallet and there doesn’t seem to be a “"golang implement scanner and provider". Additionally could you add an open source license to the repository. The default license of our contracts is Apache 2.

[jiyilanzhou]

I started to look into your delivery. You can find my notes here. However, it doesn’t seem like you are using an off-chain worker, like you originally said in the application. The documentation also doesn’t contain any example on how to use the pallet and there doesn’t seem to be a “"golang implement scanner and provider". Additionally could you add an open source license to the repository. The default license of our contracts is Apache 2.

Thank you for reply.

• So far it's just implementing a parachain of how to use Ares pallet invoke the oracle service, not implement the Aggregator, Validator, Council that used off-chain worker, These are the Ares chain contents. Future realization oracle users of paralchain will use off-chain woker sending offline transaction to ARES protocol.

• I have updated the readme documentation and add a vedio

• Due to it needs interact with the front end，so I use javascript implement scanner and provider. If not satisfied, I can use golang to implement those.

• I've added Apache License.

[jiyilanzhou]

• I already use off-chain woker summit warehouse api price to on chain，which in pallet-ocw pallet.
• Added a UI display to query history data，vedio link here

[Noc2]

Sorry for the late reply. I looked into your delivery again and I still have a few questions/comments:

• Could you also mention in the readme that you have to run make init first?
• Could you integrate the videos also into the readme?
• Could you update the inline comments in the offchain worker pallet?
• Could you create a PR to amend the original contract. For examples, replace golang with js, integrate videos and the front-end into the deliveries.

[jiyilanzhou]

Sorry for the late reply. I looked into your delivery again and I still have a few questions/comments:

• Could you also mention in the readme that you have to run make init first?
• Could you integrate the videos also into the readme?
• Could you update the inline comments in the offchain worker pallet?
• Could you create a PR to amend the original contract. For examples, replace golang with js, integrate videos and the front-end into the deliveries.

Thank you for reply.

• I aleady explained the steps of the demonstration.
• Integrate the videos into the readme.
• Added some notes to offchain worker pallet, and support on chain price aggregate
• Add a PR.

[Noc2]

Thanks for the fixes. I just commented on your amendment.

[jiyilanzhou]

Thank you very much, PR has been merged.

[Noc2]

I just took another quick look at your delivery and tried to run the tests, but I’m getting the following errors:

error[E0412]: cannot find type `BlockNumber` in this scope
  --> pallets/pallet-ares/src/mock.rs:56:31
   |
56 |     pub const AggregateInterval: BlockNumber = 15;
   |                                  ^^^^^^^^^^^ not found in this scope

warning: unused imports: `assert_noop`, `assert_ok`
 --> pallets/pallet-ares/src/tests.rs:3:21
  |
3 | use frame_support::{assert_ok, assert_noop};
  |                     ^^^^^^^^^  ^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: unused imports: `Decode`, `Encode`
 --> pallets/pallet-ares/src/tests.rs:4:13
  |
4 | use codec::{Decode, Encode};
  |             ^^^^^^  ^^^^^^

error[E0061]: this function takes 4 arguments but 3 arguments were supplied
   --> pallets/pallet-ares/src/tests.rs:29:11
    |
29  |           assert!(AresModule::register_aggregator(Origin::signed(1),"btc/eth".into(),"alice".into()).is_ok(),);
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ----------------- ---------------- -------------- supplied 3 arguments
    |                   |
    |                   expected 4 arguments
    | 
   ::: pallets/pallet-ares/src/lib.rs:140:1
    |
140 | / decl_module! {
141 | |     pub struct Module<T: Trait> for enum Call where origin: T::Origin {
142 | |         // Errors must be initialized if they are used by the pallet.
143 | |         type Error = Error<T>;
...   |
292 | |     }
293 | | }
    | |_- defined here

error: aborting due to 2 previous errors; 2 warnings emitted

[jiyilanzhou]

Sorry, due to recently added some pallet and off chain code, which causes the test cases not updated in time.

I already fix all error.

[Noc2]

Thanks for fixing everything. I’m happy to confirm that this milestone is a pass! I made some notes regarding the evaluation here and I will forward your invoice internally.

[Noc2]

Quick question did you already fill out the invoice form? I couldn't find your invoice. Feel free to also send it to me directly: david@web3.foundation

[jiyilanzhou]

Quick question did you already fill out the invoice form? I couldn't find your invoice. Feel free to also send it to me directly: david@web3.foundation

Thank you，I aleady update it. Let me know if have any questions.

[Noc2]

Thanks. I just forwarded the invoice internally.

[jiyilanzhou]

Thank you for evaluation,
We will take your comments and feedback into account and continue to enrich, optimize the project, Moving on next milestone.

[RouvenP]

hi @jiyilanzhou we just sent a test transaction. Could you please confirm if received?

[jiyilanzhou]

Hi @RouvenP thanks for the test transaction, I confirm that I have received 0.001 in the test trasnsaction.

[RouvenP]

@jiyilanzhou thanks for confirming. we sent the payment

[jiyilanzhou]

@RouvenP Thank you, I has already receive it. Can we make a announcement to public?