Skip to content

InvArch Milestone #2 Delivery#508

Merged
ashlink11 merged 5 commits intow3f:masterfrom
DSB-117:master
Aug 6, 2022
Merged

InvArch Milestone #2 Delivery#508
ashlink11 merged 5 commits intow3f:masterfrom
DSB-117:master

Conversation

@DSB-117
Copy link
Copy Markdown
Contributor

@DSB-117 DSB-117 commented Jul 21, 2022

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#950 < please fill this in with the PR number of your application.

@DSB-117 DSB-117 changed the title InvArch Milestone #2 InvArch Milestone #2 Delivery Jul 21, 2022
@ashlink11 ashlink11 self-assigned this Jul 26, 2022
@ashlink11
Copy link
Copy Markdown
Contributor

Good day @XCAstronaut, and thank you for your delivery. I quickly reviewed your original and amended applications and I will look into your delivery as soon as possible.

@DSB-117
Copy link
Copy Markdown
Contributor Author

DSB-117 commented Jul 27, 2022

Thank you, @cruikshankss! I appreciate you taking the time to look over our proposal details & reviewing our milestone delivery. Also, if your username is a Harry Potter reference, that's wicked.

@DSB-117
Copy link
Copy Markdown
Contributor Author

DSB-117 commented Aug 2, 2022

I don't mean to be a bother, but I wanted to send you a ping @cruikshankss to check on this & see how things were going.

@ashlink11
Copy link
Copy Markdown
Contributor

@XCAstronaut Good day! I haven't started testing your codebase yet but aim to do so this week. Thanks.

@ashlink11
Copy link
Copy Markdown
Contributor

Hi @XCAstronaut, I was able to start on your evaluation. I watched your demo video, read through the not-yet-published article and had a brief look through your pallets. Thank you very much for this. Ideally, I am able to easily replicate the contents of the demo video on my machine. I hope I can do this with the testing documentation and demo video together, but I feel there might be a few steps missing or instructions in different places. I will try my best though and please feel free to add details to the testing guide to make this quicker for me! Thanks!

@DSB-117
Copy link
Copy Markdown
Contributor Author

DSB-117 commented Aug 3, 2022

Please @cruikshankss, if you have any questions or feedback, and of course any points that we must address per the grant, I’d love to take this opportunity to get both your approval and insight to how we can provide friendlier documentation. Thank you again for taking the time to review our submission!

@ashlink11
Copy link
Copy Markdown
Contributor

Good day @XCAstronaut. I've been reviewing your project again and while I do think you have nice documentation, what I'm really looking for (and is part of the delivery requirements) is to give a step-by-step testing guide. I do really appreciate the demo video, but feel there are some steps missing for me to easily cruise through and replicate it. What would be ideal and would very likely help me complete your evaluation ASAP is if you could type out the series of commands/actions (complete from start to finish) assuming that I'm brand new to the project.

By the way, I just saw your comment from before. Yes, it is a Harry Potter reference. 😎🐈 Nice catch.

Updated the INV4-GIT README to include a series of step-by-step commands & actions required to test the technology from start to finish.
@DSB-117
Copy link
Copy Markdown
Contributor Author

DSB-117 commented Aug 4, 2022

Hey @cruikshankss, thank you for pointing this out. We have updated our documentation & our delivery PR to provide a step-by-step testing guide for individuals. We hope this is more thorough so that any developer can get things going & have a smooth walkthrough experience. Let me know your thoughts, please. I look forward to your review & appreciate your time as always!

Harry Potter was one of the major pieces of my childhood, so I appreciate the reference. 10 points to the W3F.

@ashlink11
Copy link
Copy Markdown
Contributor

Hi @XCAstronaut, that is an amazing testing guide. I've made it really far through already! I got stuck trying to git push origin master on the test-repo:

git: 'remote-inv4' is not a git command. See 'git --help'.

so then i tried rerunning cargo install --git https://github.com/InvArch/INV4-Git and indeed I hadn't noticed before:


    Updating git repository `https://github.com/InvArch/INV4-Git`
  Installing git-remote-inv4 v0.1.0 (https://github.com/InvArch/INV4-Git#ffba3a57)
    Updating crates.io index
    Updating git repository `https://github.com/paritytech/subxt`
error: failed to compile `git-remote-inv4 v0.1.0 (https://github.com/InvArch/INV4-Git#ffba3a57)`, intermediate artifacts can be found at `/var/folders/2z/6cfwl9fx4f1fqrwdb9625grh0000gn/T/cargo-installML6gAy`

Caused by:
  failed to select a version for the requirement `libgit2-sys = "^0.13.4"`
  candidate versions found which didn't match: 0.13.2+1.4.2, 0.13.1+1.4.2, 0.13.0+1.4.1, ...
  location searched: crates.io index
  required by package `git2 v0.14.4`
      ... which satisfies dependency `git2 = "^0.14.4"` of package `git-remote-inv4 v0.1.0 (/Users/ash/.cargo/git/checkouts/inv4-git-80ec0d2e41c6f6d4/ffba3a5)`

So it seems I might have a version issue with my lib version? During the last evaluation I did, the team I was working with said I might have an issue with my libp2p and they gave me a workaround. If you have an answer for me, it would be much appreciated because I'm unfamiliar with configuring the libp2p toolchain properly, but I will try to figure it out asap!

By the way, I've been really enjoying testing your project so far!! Excellent work!!

@ashlink11 ashlink11 merged commit c7d6748 into w3f:master Aug 6, 2022
@ashlink11
Copy link
Copy Markdown
Contributor

Hi @XCAstronaut, I was able to figure out my error and was able to complete my evaluation! More details there & congratulations! I've forwarded your invoice internally.

@RouvenP
Copy link
Copy Markdown

RouvenP commented Aug 16, 2022

hi @XCAstronaut could you send us an updated invoice with the new payment address? Thanks

@DSB-117
Copy link
Copy Markdown
Contributor Author

DSB-117 commented Aug 18, 2022

Hey @RouvenP! I’ve sent an updated invoice with the corrected payment address sometime within the last 24hrs.

I just noticed this comment, so I wanted to follow up to let you know. Thank you!

@RouvenP
Copy link
Copy Markdown

RouvenP commented Aug 19, 2022

hi @XCAstronaut, we received the invoice, thank you! We will distribute it next Wednesday. I will let you know once done.

@RouvenP
Copy link
Copy Markdown

RouvenP commented Aug 25, 2022

hi @XCAstronaut we transferred the payment two days ago.

failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
* Added proposal

* Updated the deliverables with proper tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants