Skip to content

Mobile Game Framework for Substrate Millestone 1#49

Merged
mmagician merged 2 commits intow3f:masterfrom
enfipy:master
Nov 20, 2020
Merged

Mobile Game Framework for Substrate Millestone 1#49
mmagician merged 2 commits intow3f:masterfrom
enfipy:master

Conversation

@enfipy
Copy link
Copy Markdown
Contributor

@enfipy enfipy commented Nov 11, 2020

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is done by the same account, which is responsible for the pull request of the accepted application.
  • In the case of acceptance, the payment will be transferred to the initial BTC payment address.

@enfipy enfipy changed the title Create mobile-game-framework-millestone-1.md Mobile Game Framework for Substrate Millestone 1 Nov 11, 2020
@mmagician
Copy link
Copy Markdown
Contributor

@enfipy At the moment I'm running into the following problems:

  1. docker pull docker.pkg.github.com/creator-rs/creator/android:latest doesn't work out-of-the-box, one needs to first authenticate to github with docker login, see the following thread. This seems to be an issue with GitHub itself, but perhaps you could include the workaround in your instructions?
  2. Once I succeeded with the above, I run into the following error: docker run --rm -it -v "$(pwd)/:/src" -w /src/examples/paint docker.pkg.github.com/creator-rs/creator/android cargo creator build --release

Output:

Warning: You use environment variable ANDROID_HOME that is deprecated.Please, remove it and use ANDROID_SDK_ROOT instead. Now ANDROID_HOME is used
Error: NDK error

Caused by:
    Android SDK has no platforms installed

Inside the container I can manually set ANDROID_SDK_ROOT=$ANDROID_HOME and remove the latter env var. This gets rid of the warning for me, but the NDK error still persists. Perhaps the docker image is missing some dependencies?

  1. I get the same NDK error locally. I have NDK 21.3 installed and PATH=...:/Users/marcin/Library/Android/sdk/ndk:.... Should I set some environment variables that your tool is expecting?

Let me know if you could help!

@enfipy
Copy link
Copy Markdown
Contributor Author

enfipy commented Nov 17, 2020

@mmagician Thank you a lot for your notices! I updated wiki and commit hash in this PR. Also, there were some problems with SDK 30 inside the docker so I updated it. Now it should build as expected!

Also, make sure ANDROID_SDK_ROOT and ANDROID_NDK_ROOT environment variables are set.

@enfipy
Copy link
Copy Markdown
Contributor Author

enfipy commented Nov 18, 2020

@mmagician Just yesterday Github released enhanced improved container support and we moved to it. Now you don't need to login to download docker images. Hooray 🥳

@mmagician
Copy link
Copy Markdown
Contributor

Congrats, your milestone has been approved! You will find the evaluation here

@mmagician mmagician merged commit b971734 into w3f:master Nov 20, 2020
@RouvenP
Copy link
Copy Markdown

RouvenP commented Nov 27, 2020

hi @enfipy we just sent a test transaction. Could you please confirm if received?

@enfipy
Copy link
Copy Markdown
Contributor Author

enfipy commented Nov 27, 2020

Hi @RouvenP! Yes, I received 0.01 btc

@RouvenP
Copy link
Copy Markdown

RouvenP commented Dec 1, 2020

hi @enfipy, thanks for confirming. We sent the payment.

failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
use pull_request_target instead of pull_request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants