Nolik Milestone #1

[amrbz]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#759

[takahser]

Thanks for the delivery. We will look into it as soon as possible.

[takahser]

Hi @amrbz
Thanks again for the delivery!
I took a look at it and summarized my findings here: #362.
Feel free to already have a look at it, although my PR is not merged yet.
Also, let me know if you have any questions or further comments.
Btw, I added a small PR to your repo as well containing a few minor issues I found in your docs when reading through them: https://github.com/chainify/pallet-nolik/pull/1

[amrbz]

Hi @takahser
Thank you for the fast review!
Also, thank you so much for the help with the docs, highly appreciate it 👏🏻
Will fix the mentioned issues as soon as possible.

[takahser]

Hi @amrbz
I saw you pushed an update. Just wanted to check if the code is ready for another round of review.

[amrbz]

Hi @takahser
No, not yet. I've just included the commit hashes for the current release to avoid confusion with the versions.
I'm about to push another commit with fixed issues. Thanks!

[amrbz]

Hi @takahser
I've just updated pallet-nolik and substrate-nolik-dev repositories.
Thanks for the great evaluation, it really helped a lot 👏🏻

These updates include:

• Test coverage for AddressNotOwned (#1, #2) and SameAddress (#1, #2) errors.
• Description of extrinsics functions.
• Commit hashes to the milestone delivery PR.

In addition, I've also included:

• Ability to add multiple owners to one address.
• New error type AccountInOwners which is covered with test here.
• New tests: #1, #2, #3, and #4.

Docker images are also updated and now include version tags.

[takahser]

Hi @amrbz
Thanks for the update, I'm glad my evaluation helped with improving your project. 👍
I'll look into the changes as soon as I can.

[takahser]

@amrbz thanks for your patience.
Good job on fixing the issues and thanks for so accurately documenting them in your previous comment! 👍
I'm happy with it now so I accepted your delivery, you can find my final evaluation here: https://github.com/w3f/Grant-Milestone-Delivery/blob/77bfec56a839f2aec1e8bf7a7b4d421462153039/evaluations/nolik_eval_1_takahser.md
Looking forward to M2!

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant.

Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. In case you haven't done so yet, you may also reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution and good luck with the remaining milestones, if any! As usual, please let us know if you run into any delays by leaving a comment on the application PR, or directly submitting an amendment.

[RouvenP]

hi @amrbz we transferred the payment today. Thanks!