Add hidden document monitoring in parallel orientation lock steps #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'apply orientation lock' algorithm monitors if documents stop being fully active during parallel execution, but was missing equivalent monitoring for document visibility state changes. This creates inconsistency where: - Common safety checks prevent hidden documents from starting locks - Parallel steps monitor fully-active state changes - But parallel steps don't monitor hidden state changes This fix adds monitoring for documents becoming hidden during parallel orientation lock processing, with consistent AbortError rejection. Fixes #256
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds monitoring for documents transitioning to hidden during the parallel steps of the "apply orientation lock" algorithm, aligning behavior with existing fully-active monitoring and ensuring consistent AbortError rejections.
- Add a new step to abort and reject the pending lock promise if the document’s visibility state becomes "hidden".
- Keep behavior consistent with the existing fully-active check by rejecting with AbortError and aborting the steps.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'apply orientation lock' algorithm monitors if documents stop being fully active during parallel execution, but was missing equivalent monitoring for document visibility state changes.
This creates inconsistency where:
This fix adds monitoring for documents becoming hidden during parallel orientation lock processing, with consistent AbortError rejection.
Fixes #256
The following tasks have been completed:
Implementation commitment:
Preview | Diff