Skip to content

Conversation

@Sporarum
Copy link
Contributor

@Sporarum Sporarum commented Nov 4, 2025

What I did

FIx #4729

How I did it

fix overly conservative assert

How to verify it

Commit message

the type of the iterator for an array can be a supertype of the array
elements, however an assert was checking for type equivalence, which
led to panics.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@Sporarum Sporarum changed the title fix[parser]: fix crash if supertype is used as array iterator type fix[parser]: fix crash if supertype is used as array iterator type (#4729) Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.27%. Comparing base (7fa3e56) to head (ec5e5e0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4767   +/-   ##
=======================================
  Coverage   93.27%   93.27%           
=======================================
  Files         137      137           
  Lines       19455    19455           
  Branches     3361     3361           
=======================================
  Hits        18146    18146           
  Misses        888      888           
  Partials      421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-cooper charles-cooper changed the title fix[parser]: fix crash if supertype is used as array iterator type (#4729) fix[parser]: fix crash if supertype is used as array iterator type Nov 4, 2025
@charles-cooper charles-cooper changed the title fix[parser]: fix crash if supertype is used as array iterator type fix[codegen]: fix panic for type checking iterator types Nov 4, 2025
@charles-cooper charles-cooper enabled auto-merge (squash) November 4, 2025 16:36
@charles-cooper charles-cooper merged commit a68eb57 into vyperlang:master Nov 4, 2025
160 checks passed
@Sporarum Sporarum deleted the i4729 branch November 5, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compiler crash in _parse_For_list due to incorrect value and target type assertion

2 participants