-
-
Notifications
You must be signed in to change notification settings - Fork 871
refactor[tool]: reduce docker image size #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ignore explicit
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3120 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 131 131
Lines 19067 19067
Branches 3319 3319
=======================================
Hits 17728 17728
Misses 902 902
Partials 437 437 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fubuloubu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay, need some QA to show that the images are equivalent and nothing got ignored that shouldn't be
|
this is a dup of #3111 |
I'll say the same thing I said there, hopefully @sambacha confirms or makes an update: I see a few vyper-related files that I would expect to be in the build for it to function properly. That's why it needs some QA to see if it still functions correctly with the slimmed down fileset specifically:
|
charles-cooper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking this because it doesn't include data that is needed for producing vyper --version output
|
Let me update this later today for ya |
charles-cooper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is fine. we can include it in the next release
ignore explicit
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)