Skip to content

Conversation

@sambacha
Copy link
Contributor

ignore explicit

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.97%. Comparing base (d29b521) to head (185dca3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3120   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         131      131           
  Lines       19067    19067           
  Branches     3319     3319           
=======================================
  Hits        17728    17728           
  Misses        902      902           
  Partials      437      437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, need some QA to show that the images are equivalent and nothing got ignored that shouldn't be

@charles-cooper
Copy link
Member

this is a dup of #3111

@fubuloubu
Copy link
Member

fubuloubu commented Oct 14, 2022

this is a dup of #3111

I'll say the same thing I said there, hopefully @sambacha confirms or makes an update: I see a few vyper-related files that I would expect to be in the build for it to function properly. That's why it needs some QA to see if it still functions correctly with the slimmed down fileset

specifically:

  1. vyper --version
  2. vyper SomeFile.vy (ensure it has the version pragma in it)
  3. Not sure what other things to check

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking this because it doesn't include data that is needed for producing vyper --version output

@sambacha
Copy link
Contributor Author

sambacha commented Apr 9, 2023

Let me update this later today for ya

@charles-cooper charles-cooper changed the title refactor(docker): reduce img size refactor[tool]: reduce docker image size Dec 30, 2024
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is fine. we can include it in the next release

@charles-cooper charles-cooper added this to the v0.4.4 milestone Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants