-
-
Notifications
You must be signed in to change notification settings - Fork 868
Change forwarder proxy bytecode to ERC-1167 #2281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iamdefinitelyahuman
merged 5 commits into
vyperlang:master
from
fubuloubu:refactor/forwarder-erc-1167
Feb 13, 2021
Merged
Change forwarder proxy bytecode to ERC-1167 #2281
iamdefinitelyahuman
merged 5 commits into
vyperlang:master
from
fubuloubu:refactor/forwarder-erc-1167
Feb 13, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2281 +/- ##
==========================================
+ Coverage 85.44% 85.79% +0.34%
==========================================
Files 84 85 +1
Lines 8591 8546 -45
Branches 2075 2036 -39
==========================================
- Hits 7341 7332 -9
+ Misses 748 730 -18
+ Partials 502 484 -18
Continue to review full report at Codecov.
|
jacqueswww
reviewed
Jan 27, 2021
Contributor
|
I believe the logic here is good to go, just some tests need updating. |
f80c393 to
0a2bbd1
Compare
0a2bbd1 to
b1bf214
Compare
Member
Author
Merged
iamdefinitelyahuman
approved these changes
Feb 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #2269
How I did it
Copy some stuff
How to verify it
Description for the changelog
Updated forwarder proxy bytecode to ERC-1167 compliance
Cute Animal Picture