Skip to content

Comments

docs: update precompile docs#410

Merged
charles-cooper merged 1 commit intovyperlang:masterfrom
charles-cooper:docs/register_raw_precompile
Jun 23, 2025
Merged

docs: update precompile docs#410
charles-cooper merged 1 commit intovyperlang:masterfrom
charles-cooper:docs/register_raw_precompile

Conversation

@charles-cooper
Copy link
Member

also update Address and ComputationAPI docs

What I did

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

also update Address and ComputationAPI docs
@charles-cooper charles-cooper marked this pull request as ready for review June 23, 2025 21:11
@charles-cooper
Copy link
Member Author

@bbjubjub2494 please check

Copy link
Contributor

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +566 to +568
**Important**

Unlike `execute_code`, if the computation fails (`is_error` is True), this method raises the error as an exception.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That behavior seems a bit unintuitive, especially given that it needs a note. Would it make sense to make raw_call return bytes, like in Vyper, and leave execute_code as a low-level version? Might also need a third function for completeness, one that does not throw and returns ComputationABI but does not require passing bytecode...

We don't need to deal with that now ofc

@charles-cooper charles-cooper merged commit 778d781 into vyperlang:master Jun 23, 2025
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants