create_language_translations.js: use absolute path everywhere.#5101
Open
demiankatz wants to merge 2 commits intovufind-org:release-11.0from
Open
create_language_translations.js: use absolute path everywhere.#5101demiankatz wants to merge 2 commits intovufind-org:release-11.0from
demiankatz wants to merge 2 commits intovufind-org:release-11.0from
Conversation
stweil
reviewed
Feb 26, 2026
| @@ -61,4 +61,4 @@ args.forEach(lang => { | |||
| fs.writeFileSync(`${home}/languages/ISO639-3/${lang}.ini`, lines + "\n" + existing); | |||
Contributor
There was a problem hiding this comment.
I wonder why outfile is not used here.
Member
Author
There was a problem hiding this comment.
Very good question -- appears to be an oversight, which I have corrected. Thanks!
stweil
approved these changes
Feb 26, 2026
Contributor
stweil
left a comment
stweil
left a comment
There was a problem hiding this comment.
${home}/languages was already used in the rest of the code here, and adding the missing ${home}/ in line 64 is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create_language_translations.js would fail if not run from $VUFIND_HOME; this change makes it more flexible, so you can run it from any working directory.