Skip to content

Move firebase/php-jwt to normal dependencies.#4279

Merged
demiankatz merged 1 commit intovufind-org:devfrom
EreMaijala:dev-fix-firebase-jwt-req
Mar 4, 2025
Merged

Move firebase/php-jwt to normal dependencies.#4279
demiankatz merged 1 commit intovufind-org:devfrom
EreMaijala:dev-fix-firebase-jwt-req

Conversation

@EreMaijala
Copy link
Contributor

Since it's now required by the OpenID Connect client (see #1230), it should be installed in all environments.

Since it's now required by the OpenID Connect client, it should be installed in all environments.
@EreMaijala EreMaijala requested a review from xmorave2 March 4, 2025 10:26
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @EreMaijala!

@demiankatz demiankatz added this to the 11.0 milestone Mar 4, 2025
@demiankatz demiankatz added bugfix dependencies Pull requests that update a dependency file labels Mar 4, 2025
@demiankatz demiankatz removed the request for review from xmorave2 March 4, 2025 11:22
@demiankatz demiankatz merged commit 808b919 into vufind-org:dev Mar 4, 2025
6 checks passed
@demiankatz demiankatz deleted the dev-fix-firebase-jwt-req branch March 4, 2025 11:22
EreMaijala added a commit to NatLibFi/NDL-VuFind2 that referenced this pull request Mar 6, 2025
Since it's now required by the OpenID Connect client, it should be installed in all environments.

(cherry picked from commit 808b919)
EreMaijala added a commit to NatLibFi/NDL-VuFind2 that referenced this pull request Mar 6, 2025
Since it's now required by the OpenID Connect client, it should be installed in all environments.

(cherry picked from commit 808b919)
(cherry picked from commit 12317df)
@demiankatz demiankatz modified the milestones: 11.0, 10.2 Mar 15, 2025
demiankatz pushed a commit that referenced this pull request Mar 15, 2025
Since it's now required by the OpenID Connect client, it should be installed in all environments.
ckaz pushed a commit to finc/vufind that referenced this pull request Mar 20, 2025
Since it's now required by the OpenID Connect client, it should be installed in all environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants