Introduce and use ShortlinksService#3749
Merged
demiankatz merged 8 commits intovufind-org:devfrom Jun 13, 2024
Merged
Conversation
demiankatz
added
the
architecture
demiankatz
added a commit
to demiankatz/vufind
that referenced
this pull request
Jun 4, 2024
aleksip
approved these changes
Jun 13, 2024
| * @return void | ||
| * @throws Exception | ||
| */ | ||
| public function beginTransaction(): void; |
Contributor
There was a problem hiding this comment.
I would move these transaction methods to a separate feature interface since they are not specific to shortlinks.
Member
Author
There was a problem hiding this comment.
Excellent idea; I suspect they may eventually get refactored to the base class, but having their own interface is helpful wherever they end up in the long run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Shortlinks port in #2233 moves a lot of logic into the database service; this PR takes a different approach to keep higher-level logic in a higher-level class. I'll reconcile the differences once it's merged.
TODO: