Skip to content

Expand User resource entity interface#3743

Merged
demiankatz merged 4 commits intovufind-org:devfrom
padmasreegade:user-resource-entity-interface
Jun 3, 2024
Merged

Expand User resource entity interface#3743
demiankatz merged 4 commits intovufind-org:devfrom
padmasreegade:user-resource-entity-interface

Conversation

@padmasreegade
Copy link
Contributor

Implemented setter and getter methods for UserResourceEntityInterface.

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks, @padmasreegade! I made one small fix (removing an unnecessary nullsafe operator from setUser) since it didn't seem worth wasting your time with a review on such a small detail. :-)

@demiankatz demiankatz merged commit a634737 into vufind-org:dev Jun 3, 2024
@padmasreegade padmasreegade deleted the user-resource-entity-interface branch June 4, 2024 12:34
@demiankatz demiankatz added this to the 10.0 milestone Jun 5, 2024
@demiankatz demiankatz added the architecture pull requests that involve significant refactoring / architectural changes label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

architecture pull requests that involve significant refactoring / architectural changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants