Expand Ratings Entity Interface#3739
Merged
demiankatz merged 3 commits intovufind-org:devfrom Jun 3, 2024
Merged
Conversation
demiankatz
requested changes
Jun 3, 2024
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @padmasreegade -- just a few minor points in need of adjusting.
| * | ||
| * @return RatingsEntityInterface | ||
| */ | ||
| public function setRating(string $rating): RatingsEntityInterface; |
Member
There was a problem hiding this comment.
This should be int rather than string.
| */ | ||
| public function setResource(ResourceEntityInterface $resource_id): RatingsEntityInterface | ||
| { | ||
| $this->resource_id = $resource_id?->getId(); |
Member
There was a problem hiding this comment.
You don't need to use the nullsafe operator (?->) here since the incoming value is not allowed to be null. I would also call the argument $resource instead of $resource_id since it is a full object, not just an ID.
| * | ||
| * @return RatingsEntityInterface | ||
| */ | ||
| public function setRating(string $rating): RatingsEntityInterface |
Member
There was a problem hiding this comment.
See above -- when interface is changed, this will have to match.
demiankatz
requested changes
Jun 3, 2024
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Sorry, @padmasreegade, I just noticed one more small thing that I missed on my first review!
| * @property int $id | ||
| * @property string $user_id | ||
| * @property string $resource_id | ||
| * @property string $rating |
Member
There was a problem hiding this comment.
This should be an int as well.
demiankatz
added
the
architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented setter and getter methods for RatingsEntityInterface.