Introduce ExternalSessionService.#3732
Merged
demiankatz merged 8 commits intovufind-org:devfrom Jun 13, 2024
Merged
Conversation
demiankatz
added
the
architecture
1 task
EreMaijala
requested changes
Jun 13, 2024
module/VuFind/src/VuFind/Db/Service/ExternalSessionServiceInterface.php
Outdated
Show resolved
Hide resolved
Contributor
|
@demiankatz I'll see if I can add a Mink test for this using SimulatedSSO. |
Member
Author
|
Thanks for the review, @EreMaijala -- I've addressed your comments (including changing getExternalSessionById to getExternalSessionByExternalSessionId, which is long and redundant but more clear!). Thanks also for the offer of test coverage -- more never hurts, though it does appear that we're at least using some parts of the service in ShibbolethLogoutNotificationTest. |
Contributor
|
@demiankatz Indeed, but I think it's still worth adding it to SimulatedSSO test so that it's the "real thing" adding the session mapping. |
Member
Author
|
I'm currently working on adding the expiration command... |
EreMaijala
approved these changes
Jun 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates most of the external session handling logic to a new database service. The expiration cleanup command can be ported after #3714 is merged, since that work requires changes pending in that other PR.
All tests are passing, but I don't have a real-world environment to test this with, so help with that would be appreciated!