Update feedback admin template to use FeedbackEntityInterface.#3731
Merged
demiankatz merged 1 commit intovufind-org:devfrom Jun 7, 2024
Merged
Update feedback admin template to use FeedbackEntityInterface.#3731demiankatz merged 1 commit intovufind-org:devfrom
demiankatz merged 1 commit intovufind-org:devfrom
Conversation
demiankatz
added
the
architecture
EreMaijala
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR puts some finishing touches on the feedback admin module, updating the template to use the FeedbackEntityInterface where appropriate. This was a little trickier than anticipated because of the way Laminas\Db returns results. Some data remapping was necessary to convert what Laminas\Db provides into the future format we'll get from Doctrine (which offers proper entity support and better separation of fields). The solution here feels like a bit of a hack, but it works, it's temporary, and it only impacts a rarely-used admin feature. Seems worth patching in to further minimize template diffs vs. #2233.