Expand Auth hash entity interface#3712
Merged
demiankatz merged 6 commits intovufind-org:devfrom May 28, 2024
Merged
Conversation
demiankatz
requested changes
May 28, 2024
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @padmasreegade, this looks like an excellent start. Just a couple small suggestions.
demiankatz
reviewed
May 28, 2024
demiankatz
approved these changes
May 28, 2024
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Looks good to me; thank you, @padmasreegade! I've pushed up a commit with a couple of very small edits I made right before testing (to hopefully further clarify the role of the session ID). Seemed easier to just change this rather than to make you go through another review cycle, since the edits are trivial. :-)
demiankatz
added
the
architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented setter and getter methods for AuthHashEntityInterface