Expand UserList entity interface#3660
Conversation
demiankatz
left a comment
There was a problem hiding this comment.
@padmasreegade, you can run composer fix from the $VUFIND_HOME directory to correct most of the remaining style issues automatically. Once you've done that, please let me know and I'll take a closer look at the changes!
|
Looks like there are now some phpstan observations that require manual fixing. Let me know if you need any more help; otherwise, I'll just wait until you request a review from me. :-) |
Thank you for offering, Demian! I'm working on them, will let you know if I need something 😄 |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @padmasreegade! See below for a few comments and suggestions.
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @padmasreegade -- a few more issues/suggestions.
Also, a broader matter that was just raised in #3638: a lot of this code has inconsistent punctuation in the comments. Some method descriptions end with periods and others do not. It would probably be best to make this consistent one way or the other. If you have a preference, feel free to go ahead and edit accordingly. If you're not sure, you can watch the conversation on #3638 and see where it leads.
…r method to get User based in user_id
demiankatz
left a comment
There was a problem hiding this comment.
Progress is looking good! I realize you haven't requested another review, so apologies if any of these suggestions are premature. I have a meeting coming up soon, so I thought I'd leave some feedback before I get busy! :-)
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @padmasreegade -- I think this is nearly done; I just have a few minor remaining suggestions.
I suspect that several of the comments I made on the row class will require matching changes to the entity interface; please double-check those as you go -- I thought it better not to leave double-comments. :-)
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @padmasreegade -- this is ready to merge!
Implemented setter and getter methods for UserList.