Skip to content

Refactor libraryCardsEnabled method to AccountCapabilities class.#3629

Merged
demiankatz merged 24 commits intovufind-org:devfrom
demiankatz:refactor-card-check
May 17, 2024
Merged

Refactor libraryCardsEnabled method to AccountCapabilities class.#3629
demiankatz merged 24 commits intovufind-org:devfrom
demiankatz:refactor-card-check

Conversation

@demiankatz
Copy link
Member

@demiankatz demiankatz commented Apr 29, 2024

This is a first step toward decoupling library cards enabled checks from user row objects. We need to do this in order to begin moving more logic into the UserCardService, which in turn is needed to complete #3625.

I don't think there's any way to do this that isn't somewhat messy. I welcome suggestions for better approaches.

TODO:

@demiankatz demiankatz marked this pull request as draft April 29, 2024 20:14
@demiankatz demiankatz marked this pull request as ready for review May 14, 2024 16:58
@demiankatz demiankatz requested a review from EreMaijala May 14, 2024 16:58
@demiankatz
Copy link
Member Author

I think this is now ready for review. As discussed elsewhere (probably on Slack) it might make sense to move the inPrivacyMode method into AccountCapabilities as well... but this will only strengthen the existing circular dependencies, so I'm not sure if it's a good idea. Either way, I think that's a separate matter that can be handled outside of this current PR.

@demiankatz demiankatz added this to the 10.0 milestone May 14, 2024
@demiankatz demiankatz added the architecture pull requests that involve significant refactoring / architectural changes label May 14, 2024
Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the description I was expecting something much more messy than this. Looks good to me!

@demiankatz
Copy link
Member Author

Based on the description I was expecting something much more messy than this. Looks good to me!

It started out a lot messier before I split big chunks of it off into separate PRs and simplified everything. :-)

@demiankatz demiankatz merged commit 7ceb220 into vufind-org:dev May 17, 2024
@demiankatz demiankatz deleted the refactor-card-check branch May 17, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

architecture pull requests that involve significant refactoring / architectural changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants