Refactor libraryCardsEnabled method to AccountCapabilities class.#3629
Merged
demiankatz merged 24 commits intovufind-org:devfrom May 17, 2024
Merged
Refactor libraryCardsEnabled method to AccountCapabilities class.#3629demiankatz merged 24 commits intovufind-org:devfrom
demiankatz merged 24 commits intovufind-org:devfrom
Conversation
Member
Author
|
I think this is now ready for review. As discussed elsewhere (probably on Slack) it might make sense to move the |
This was referenced May 14, 2024
EreMaijala
approved these changes
May 16, 2024
Contributor
EreMaijala
left a comment
There was a problem hiding this comment.
Based on the description I was expecting something much more messy than this. Looks good to me!
Member
Author
It started out a lot messier before I split big chunks of it off into separate PRs and simplified everything. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first step toward decoupling library cards enabled checks from user row objects. We need to do this in order to begin moving more logic into the UserCardService, which in turn is needed to complete #3625.
I don't think there's any way to do this that isn't somewhat messy. I welcome suggestions for better approaches.
TODO: