Refactor constants/Laminas app setup to separate files.#2301
Merged
demiankatz merged 2 commits intovufind-org:dev-9.0from Feb 2, 2022
Merged
Refactor constants/Laminas app setup to separate files.#2301demiankatz merged 2 commits intovufind-org:dev-9.0from
demiankatz merged 2 commits intovufind-org:dev-9.0from
Conversation
Member
Author
|
@EreMaijala, this PR is an attempt to extract and refine the refactoring of public/index.php from #2233, so we can merge it independently of the larger Doctrine project. Please let me know what you think! |
demiankatz
changed the title
Contributor
|
@demiankatz Just out of curiosity: why the separate |
Member
Author
Yes, when we add Doctrine, we need to access the Application from the Doctrine console configuration file. |
EreMaijala
reviewed
Feb 2, 2022
EreMaijala
requested changes
Feb 2, 2022
EreMaijala
approved these changes
Feb 2, 2022
3 tasks
EreMaijala
pushed a commit
to EreMaijala/vufind
that referenced
this pull request
Apr 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO