Skip to content

Conversation

@rosvik
Copy link
Contributor

@rosvik rosvik commented Jun 19, 2019

Description

I added a Norwegian (bokmål) translation

Motivation and Context

I already made a translation for my project, thought I would share it.

How Has This Been Tested?

It hasn't.

Markup:

¯\(ツ)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel vercel bot temporarily deployed to staging June 19, 2019 20:39 Inactive
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #7587 into next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7587      +/-   ##
==========================================
+ Coverage   86.94%   86.94%   +<.01%     
==========================================
  Files         325      326       +1     
  Lines        8534     8536       +2     
  Branches     2153     2153              
==========================================
+ Hits         7420     7422       +2     
  Misses       1024     1024              
  Partials       90       90
Impacted Files Coverage Δ
packages/vuetify/src/locale/no.ts 100% <100%> (ø)
packages/vuetify/src/locale/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0e4807...9b795a1. Read the comment docs.

Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add an entry for this in vue-cli-plugin-vuetify
file: util/locales.js

@rosvik
Copy link
Contributor Author

rosvik commented Jun 20, 2019

Sure, added the entry now.

vuetifyjs/vue-cli-plugins#93

jacekkarczmarczyk pushed a commit to vuetifyjs/vue-cli-plugins that referenced this pull request Jun 20, 2019
@jacekkarczmarczyk jacekkarczmarczyk merged commit b78fe28 into vuetifyjs:next Jun 20, 2019
@jacekkarczmarczyk
Copy link
Member

Thanks!

@rosvik rosvik deleted the next branch June 20, 2019 07:34
@lock lock bot locked as resolved and limited conversation to collaborators Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants