Skip to content

Conversation

@amonys19212
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Apr 25, 2025

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit bdd06a2
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/680ee3aedcb1e400088f75d3

@posva
Copy link
Member

posva commented Apr 25, 2025

Thanks but only once Nuxt 4 is released, it should be tested and the version adapted:

CleanShot 2025-04-25 at 14 11 44

@posva posva closed this Apr 25, 2025
@amonys19212
Copy link
Contributor Author

Thank you very much for your reply. I am currently testing Nuxt 4 (Nightly Channel). Unfortunately, due to the module’s version settings, nuxt/pinia is not able to run on Nuxt 4 at the moment. However, the older version (v0.9.0) is able to run successfully.

Example Nuxt v4.0.0-29092227.317ced76 + pinia v2.3.1 + @pinia/nuxt v0.9.0
https://stackblitz.com/edit/nuxt-starter-zayjogfc

https://www.npmjs.com/package/nuxt-nightly?activeTab=versions

@posva posva reopened this Apr 26, 2025
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of the nuxt-nightly having a v4 available!
Thanks for testing it out!

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 26, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@pinia/nuxt@2978
npm i https://pkg.pr.new/pinia@2978
npm i https://pkg.pr.new/@pinia/testing@2978

commit: bdd06a2

@posva
Copy link
Member

posva commented Apr 26, 2025

You should be able to use the publish any commit version and polish the PR as needed

@codecov
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.35%. Comparing base (39b8937) to head (bdd06a2).
Report is 8 commits behind head on v3.

Additional details and impacted files
@@           Coverage Diff           @@
##               v3    #2978   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files          17       17           
  Lines        1400     1400           
  Branches      211      211           
=======================================
  Hits         1279     1279           
  Misses        120      120           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nathanchase
Copy link

This should get probably get priority now that 4.0 is in alpha: https://github.com/nuxt/nuxt/releases/tag/v4.0.0-alpha.1

 WARN  Module pinia is disabled due to incompatibility issues:                                            
 - [nuxt] Nuxt version ^3.15.0 is required but currently using 4.0.0-alpha.1

@github-project-automation github-project-automation bot moved this to 🆕 Triaging in Pinia Roadmap Jun 3, 2025
@posva posva moved this from 🆕 Triaging to 💬 In discussion in Pinia Roadmap Jun 3, 2025
@posva posva moved this from 💬 In discussion to 🧑‍💻 In progress in Pinia Roadmap Jun 3, 2025
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it works. It does warn

 WARN  [nuxt] Expected @nuxt/kit to be at least 4.0.0-alpha.1 but got 3.17.5. This might lead to unexpected behavior. Check your package.
json or refresh your lockfile.

But I suppose this is expected in the meantime

@posva posva merged commit 925e93c into vuejs:v3 Jun 4, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from 🧑‍💻 In progress to ✅ Done in Pinia Roadmap Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants