Skip to content

fix(language-core): do not emit undefined for model with falsy default value #5198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025
Merged

fix(language-core): do not emit undefined for model with falsy default value #5198

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c93706e
do not emit undefined for model with falsy default value
RylanBueckert-Broadsign Feb 19, 2025
4ceea27
Update packages/language-core/lib/codegen/script/scriptSetup.ts
RylanBueckert-Broadsign Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/language-core/lib/codegen/script/scriptSetup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ function* generateModelEmit(
const [propName, localName] = getPropAndLocalName(scriptSetup, defineModel);
yield `'update:${propName}': [value: `;
yield* generateDefinePropType(scriptSetup, propName, localName, defineModel);
if (!defineModel.required && !defineModel.defaultValue) {
if (!defineModel.required && !('defaultValue' in defineModel)) {
yield ` | undefined`;
}
yield `]${endOfLine}`;
Expand Down
Loading