Skip to content

Conversation

@jh-leong
Copy link
Member

In vuejs/core#12227, I attempted to fix the default type restriction in PropOptions, but it caused CI failures (https://github.com/vuejs/ecosystem-ci/actions/runs/11435154446/job/31810009674).

Previously, default allowed arbitrary objects, leading to incorrect tests passing.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2024

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4934

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4934

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4934

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4934

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4934

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4934

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4934

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4934

commit: 583c5d7

@KazariEX KazariEX merged commit b17ef78 into vuejs:master Oct 21, 2024
5 checks passed
@jh-leong jh-leong deleted the fix/defineProp_test branch October 21, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants