Skip to content

fix(component-meta): error when signatures is undefined #4930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix(component-meta): error when signatures is undefined #4930

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b73f9e
fix: default to empty array if no signatures are found
Oct 18, 2024
e321381
Update packages/component-meta/lib/base.ts
Hannesrasmussen Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/component-meta/lib/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,8 +540,8 @@
function resolveSlotProperties(prop: ts.Symbol): SlotMeta {
const propType = typeChecker.getNonNullableType(typeChecker.getTypeOfSymbolAtLocation(prop, symbolNode));
const signatures = propType.getCallSignatures();
const paramType = signatures[0].parameters[0];
const paramType = signatures.length > 0 ? signatures[0].parameters[0] : [];
const subtype = paramType ? typeChecker.getTypeOfSymbolAtLocation(paramType, symbolNode) : typeChecker.getAnyType();

Check failure on line 544 in packages/component-meta/lib/base.ts

View workflow job for this annotation

GitHub Actions / build 

Argument of type 'Symbol | never[]' is not assignable to parameter of type 'Symbol'.

Check failure on line 544 in packages/component-meta/lib/base.ts

View workflow job for this annotation

GitHub Actions / build (18, macos-latest) 

Argument of type 'Symbol | never[]' is not assignable to parameter of type 'Symbol'.

Check failure on line 544 in packages/component-meta/lib/base.ts

View workflow job for this annotation

GitHub Actions / build (18, ubuntu-latest) 

Argument of type 'Symbol | never[]' is not assignable to parameter of type 'Symbol'.
let schema: PropertyMetaSchema;
let declarations: Declaration[];

Expand Down
Loading