Skip to content

fix(runtime-core): ensure props and attrs are shallow readonly in dev #8222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edison1105 wants to merge 6 commits into from
Closed

fix(runtime-core): ensure props and attrs are shallow readonly in dev #8222

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b53c983
fix(runtime-core): ensure props are shallow readonly in dev
edison1105 May 3, 2023
3024901
chore: update test case
edison1105 May 3, 2023
9e70a0e
Merge branch 'main' into fix/8216
edison1105 Oct 20, 2023
e826054
Merge branch 'main' into fix/8216
edison1105 Apr 21, 2024
4ba22c6
[autofix.ci] apply automated fixes
autofix-ci[bot] Apr 21, 2024
11656af
chore: ensure attrs are shallow readonly
edison1105 Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/runtime-core/__tests__/componentProps.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,12 @@ describe('component props', () => {
render(h(Comp, { foo: 1 }), root)
expect(props).toEqual({ foo: 1 })
expect(attrs).toEqual({ foo: 1 })
expect(props).toBe(attrs)
expect(props).toStrictEqual(attrs)

render(h(Comp, { bar: 2 }), root)
expect(props).toEqual({ bar: 2 })
expect(attrs).toEqual({ bar: 2 })
expect(props).toBe(attrs)
expect(props).toStrictEqual(attrs)
})

test('boolean casting', () => {
Expand Down
10 changes: 7 additions & 3 deletions packages/runtime-core/src/componentRenderUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
isCompatEnabled,
warnDeprecation
} from './compat/compatConfig'
import { shallowReadonly } from '@vue/reactivity'

/**
* dev only flag to track whether $attrs was used during render.
Expand Down Expand Up @@ -78,7 +79,7 @@ export function renderComponentRoot(
proxyToUse,
proxyToUse!,
renderCache,
props,
__DEV__ ? shallowReadonly(props) : props,
setupState,
data,
ctx
Expand All @@ -95,7 +96,7 @@ export function renderComponentRoot(
result = normalizeVNode(
render.length > 1
? render(
props,
__DEV__ ? shallowReadonly(props) : props,
__DEV__
? {
get attrs() {
Expand All @@ -107,7 +108,10 @@ export function renderComponentRoot(
}
: { attrs, slots, emit }
)
: render(props, null as any /* we know it doesn't need it */)
: render(
__DEV__ ? shallowReadonly(props) : props,
null as any /* we know it doesn't need it */
)
)
fallthroughAttrs = Component.props
? attrs
Expand Down