Skip to content

fix(runtime-dom): before update should also set css vars #11561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 14, 2024
Merged

fix(runtime-dom): before update should also set css vars #11561

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
63bb92b
fix(runtime-dom): apply css vars before mount and before update
linzhe141 Aug 8, 2024
3c7cdec
chore: update
linzhe141 Aug 9, 2024
c90fa1d
chore: update
linzhe141 Aug 9, 2024
da120f3
chore: revert
linzhe141 Aug 9, 2024
b608db0
chore: update test
linzhe141 Aug 9, 2024
06a2972
chore: Merge branch 'main' into fix-useCssVars
linzhe141 Aug 16, 2024
58b67d1
Update useCssVars.spec.ts
edison1105 Oct 30, 2024
8239e9d
[autofix.ci] apply automated fixes
autofix-ci[bot] Oct 30, 2024
12f6c60
Merge branch 'main' into fix-useCssVars
yyx990803 Nov 14, 2024
8e48b10
[autofix.ci] apply automated fixes
autofix-ci[bot] Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/runtime-dom/src/helpers/useCssVars.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
type VNode,
getCurrentInstance,
onBeforeMount,
onBeforeUpdate,
onMounted,
onUnmounted,
warn,
Expand Down Expand Up @@ -47,6 +48,10 @@ export function useCssVars(getter: (ctx: any) => Record<string, string>) {
watchPostEffect(setVars)
})

onBeforeUpdate(() => {
watchPostEffect(setVars)
Copy link
Member

@yyx990803 yyx990803 Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just call setVars and not create another watcher on each update.

Copy link
Contributor Author

@linzhe141 linzhe141 Aug 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I just call setVars before update, the vnode is still a v-if comment, and it doesn't make sense to set custom properties for this comment.

image

But when I combine it with watchPostEffect, the vnode is correct.

image

Copy link
Member

@edison1105 edison1105 Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or use queuePostFlushCb instead?

Copy link
Contributor Author

@linzhe141 linzhe141 Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

})

onMounted(() => {
const ob = new MutationObserver(setVars)
ob.observe(instance.subTree.el!.parentNode, { childList: true })
Expand Down